search

entur / android-nfc-lib

Library for working with internal + external NFC readers on Android
European Union Public License 1.2
23 stars 2 forks source link

AcrReaderListener catches RemoteCommandException #14

Closed Hekkii closed 2 years ago

Hekkii commented 2 years ago

reader.getPicc() might throw uncaught RemoteCommandException.

Vet ikke om det heller burde catches i getPicc() som igjen kaster AcrReaderException. Du har kanskje noen tanker @skjolber ?

skjolber commented 2 years ago

This looks like a copy paste error, I'll have a fix soon. Basically RemoteCommandException is the superclass and ACR and MCR variants extend it and those are to be caught.

skjolber commented 2 years ago

See https://github.com/entur/android-nfc-lib/compare/issue14?expand=1

skjolber commented 2 years ago

Fixed in 1.0.10