feat: add gha workflows

entur / helm-charts

0 stars 3 forks source link

feat: add gha workflows #6

Closed frealmyr closed 2 years ago

frealmyr commented 2 years ago

Adds the following github actions:

PR:

Checks if PR title is in conventional commit format, re-runs if the PR title is updated
Runs helm unittests (reuse, shoutout to @AlexanderBrevig)
Runs helm linting with config from root (chart_schema.yaml, config.yaml, lintconf.yaml)
Creates temporary kubernetes-in-docker (KIND) cluster
Installs helm chart to temporary kubernetes cluser

Merge-to-main:

Runs helm unittests (reuse, shoutout to @AlexanderBrevig)
Bumps version in charts/common/Chart.yaml (For semver logic) based on git log.
Creates a helm chart release
- Updates github pages helm repository with new release and artifact

frealmyr commented 2 years ago

If this helm CT plugin proves to be too much maintenance, then we can yeet it and use a more custom KIND setup.

https://github.com/entur/helm-charts/pull/6/files#diff-7ad0e0d3d9a2bed6507f02f425ed28e32dd6201e68b6b2c0d7c5c202f6cc8b64R35-R73

AlexanderBrevig commented 2 years ago

Which LSP are you using? Seems to have slightly different (better and stricter) preferences than standard Yamlls, we should make sure to use the same going forward. Looks good, except the failing helm lint step. I'll approve as I suspect you'll fix this before merging.

frealmyr commented 2 years ago

Which LSP are you using? Seems to have slightly different (better and stricter) preferences than standard Yamlls, we should make sure to use the same going forward. Looks good, except the failing helm lint step. I'll approve as I suspect you'll fix this before merging.

It's the standard helm lint command with --strict, it failed since we need to add a values-ci-test.yaml that enables all features for the CI checks. :)

https://github.com/entur/gh-workflows/blob/main/.github/workflows/pr-tests-helm.yml#L41