Closed derhuerst closed 1 year ago
Interesting, I think the jib configuration is missing a from
part that defines the correct jdk version as the base image, which should be 17.
To make sure the Docker image is actually working, we could run e.g. docker run --rm -i entur/lamassu --version
in the CI before pushing, assuming that
--version
,java -jar lamassu.jar
.What do you think?
See #255, I verified this fix locally with mvn jib:dockerBuild and using the result image in docker-compose.
I'm sure it's possible to do something more fancy, but it should at least be fixed now.
What do you think about adding a --version
flag and calling it from the CI before publishing? I think it would help preventing such bugs in the future.
I'm not sure there's a straight-forward way of doing this and actually verifying that the application will load without actually needing all the bean dependencies to be setup as well. Probably not worth it.
Running the latest
entur/lamassu
Docker image (entur/lamassu@sha256:0b48414b4f635232d617a550d9f0f05d9a039fca8565f25721591eec4d2707b2
), I get the following error messages, and then it crashes.