search

entur / lamassu

Mobility hub
European Union Public License 1.2
5 stars 7 forks source link

Support consuming GBFS v3 #389

Closed testower closed 4 months ago

testower commented 5 months ago

Summary

This PR adds support for consuming v3 feeds.

Depends on https://github.com/entur/gbfs-loader-java/pull/156

Note: The v3 endpoint is still in beta - discovery at /gbfs/v3beta/manifest.json, final location TBD.

Some fields may be missing from the mappers (https://github.com/entur/lamassu/tree/95493567a2cb437f803f1788aff7429860dd243b/src/main/java/org/entur/lamassu/mapper/feedmapper/v3) fixed in 2e4790f

The mappers have a lot of apparent duplication with the v2 mappers, but types are not compatible so not possible to dedupe. A better way to implement this mappers may be via mapstruct or cloning with kryo?

There are also som TODOs scattered around with open questions, that could be dealt with in followup PRs.

Issue

Solves #333

Unit tests

Added test coverage via integration tests

Documentation

Added documentation to README

sonarcloud[bot] commented 4 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
12.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud