search

enturn / brackets-quick-search

Notepad++ style smart highlighting extension for Brackets editor.
36 stars 11 forks source link

Find in file and find in project menu won't open in latest brackets@master #17

Closed beeftornado closed 9 years ago

beeftornado commented 9 years ago

Opening the find menu throws an exception. I think the dummy find bar the extension creates now needs an isClosed method.

screen shot 2014-10-23 at 1 20 57 pm

mateusmedeiros commented 9 years ago

I think adding isClosed() function to DummyFindBar is the most unobtrusive and simple way of fixing this, so I went ahead and submitted a PR.

Let me know if there's any better way to fix this.

enturn commented 9 years ago

Thanks beeftornado. Hopefully commit c6b64a7fdb2c59dae9e6d7d29fc292727d2bf5e1 should fix it. I added other functions from FindBar too in case they're ever used.

Edit: Sorry mateusmedeiros, already committed before I saw your post.

mateusmedeiros commented 9 years ago

No prob. Adding the other functions will be less error-prone too.

Wikunia commented 9 years ago

Thanks it's working! You should register your updates ;)

om3 commented 9 years ago

I'm getting same error, but I need to use extensions.

Wikunia commented 9 years ago

@om3 the bug is fixed but maybe it isn't registered yet @enturn. So you need to update it from url :)

om3 commented 9 years ago

Hi @Wikunia , how to update? I'm new in git.

om3 commented 9 years ago

Thanks, I solved installing it.

beeftornado commented 9 years ago

For anyone else who finds this thread, all you need to do is open up your Brackets extension manager, and click the link in the bottom left corner that says "Install from URL". Then paste the URL to this github repo, https://github.com/enturn/brackets-quick-search.