search

enturn / brackets-quick-search

Notepad++ style smart highlighting extension for Brackets editor.
36 stars 11 forks source link

Brackets 1.0 incompatibility #19

Closed genericandy closed 9 years ago

genericandy commented 9 years ago

All of the Brackets "Find" menu commands do not work with this extension active in Brackets 1.0

khaney commented 9 years ago

I was able to temporarily fix this by adding this line to main.js at line 178:

DummyFindBar.prototype.isClosed = function() { return true; };
miqmago commented 9 years ago

+1 For me it solves the problem too. I've seen that in the current branch it is already resolved so we will have to wait for a publishing...

ben-bradley commented 9 years ago

+1 to the fix

ben-bradley commented 9 years ago

Also, I checked out some of the other highlighter extensions and found that none of them come close to being as awesome as this one. Well done! =)

imrefazekas commented 9 years ago

Gold found! Thanks, it is working now.

le717 commented 9 years ago

@enturn Could you push the latest changes in master to the extension registry ASAP? We keep getting a number of reports over at the Brackets repo about this extension breaking v1.0.

Thanks!

PwrSrg commented 9 years ago

+1 for publish

phreezer commented 9 years ago

+1 Saved my life

enturn commented 9 years ago

Version 1.1.4 is now in the extension registry.