search

enturn / brackets-quick-search

Notepad++ style smart highlighting extension for Brackets editor.
36 stars 11 forks source link

shift+arrow key to highlight a section of text will break when match is found #2

Closed raybarnhart closed 11 years ago

raybarnhart commented 11 years ago

This bug is only active when quicksearch is turned on.

Steps to reproduce: 1) find a long line of code that has at least one word that will appear elsewhere in your file 2) place your cursor at the right end of that line 3) hold down shift and press the left arrow key to begin selecting text like you normally would to copy/cut/delete it 4) keep pressing the left arrow key until you've selected a chunk of code / word that has appeared elsewhere in the document

Behavior: the word will become highlighted and it will highlight the rest of the instances of that word (correct) but will break your shift-selection context (incorrect) and if you keep pressing arrow-left while holding shift, instead of growing the selected context, your selected context will shrink because your cursor is now at the right side of the line again. This ONLY happens when going from right to left. Shift + right arrow works just fine.

Expected behavior: the word will become highlighted and it will highlight the rest of the instances of that word, and then when user continues to hold shift and press left arrow the selection context will grow.

highlightbug

Hopefully that made sense!

enturn commented 11 years ago

Thanks raybarnhart. The cursor position was being moved on search. This should be fixed now. I also noticed that non-words are being selected. I fixed that while still allowing inner non-word characters to match (ie hyphenated words, etc).