search

enturn / brackets-quick-search

Notepad++ style smart highlighting extension for Brackets editor.
36 stars 11 forks source link

Highlights hides ctrl+b multi-selections #21

Closed mrpeu closed 6 years ago

mrpeu commented 9 years ago

The highlighting used completely hinders the "mutli search and select" feature of brackets.

Sublime text resolve this by using a border around the "found" items as seen here(https://www.sublimetext.com/forum/viewtopic.php?f=2&t=17042) They also apply a different style for the selected item and the "found" items.

Aldredcz commented 9 years ago

+1 on this. I love this extension and I also live the Ctrl+B multiselect,.. too bad it's not possible to use these two features together.

@mrpeu I discovered partial solution. If you add "showCursorWhenSelecting": true into your preferences file (Debug > Open Preferences File), you can distinguish actually selected strings by blinking cursor... At least something.

mrpeu commented 9 years ago

@Aldredcz Good tip, thanks.

joelmukuthu commented 9 years ago

If you didn't know, brackets has a highlightMatches option which does what this extension does, but doesn't cause this problem. https://github.com/adobe/brackets/wiki/How-to-Use-Brackets#list-of-supported-preferences EDIT: this option doesn't highlight the match occurrences on the scrollbar though

mrpeu commented 9 years ago

Ups, that is the purpose of this extension isn't it?

Thank you @joelmukuthu

joelmukuthu commented 9 years ago

@mrpeu more or less, yeah :)

enturn commented 9 years ago

That's awesome joelmukuthu. I never new that option existed. I might be able to default the setting to 'wordsOnly' and use the interal search cursor to add in the scrollbar tickmarks, then this extension will work almost the same as now but more stable and clearer styling. Also this extension alows toggling it from the menu, although that doesn't seem to work anymore, but that's for another ticket.

joelmukuthu commented 9 years ago

@enturn that would be great, especially allowing the colours of selections to be themable