Closed malomarrec closed 2 years ago
Sure, let me take a look at this. Do you know why setup is failing if there's no dist folder?
Looking more into this it looks like clasp
was updated at some point and now tries to add the .clasp.json file and appscript.json manifest into the rootDir (./dist in this case).
Was able to find a relevant issue described here: https://github.com/google/clasp/issues/869 Relevant code in PR that changed this behavior: https://github.com/google/clasp/pull/865/files#diff-b6d810b0306723c2b160e529addd463ae24be806303358ff1f6a2209bc13357dR108-R114
Thanks for flagging this. Need to think if running build first is the best solution though. May need to just reorganize files and update README.
I'm going to create a new PR here: https://github.com/enuchi/React-Google-Apps-Script/pull/137
This is somewhat of a workaround and less than ideal, but think it is the least disruptive to the project and allows users to just follow the README steps for setup. It should work now without a dist directory.
When using this repo for the first time and following README instructions, users won't have a build
dist
in the folder. Runningnm run setup
will fail. Addingnpm run build
innpm run setup
makes it so you can "just follow the README instructions".