search

env0 / k8s-modules

3 stars 2 forks source link

Prefer hashicorp/kubernetes over gavinbunney/kubectl provider #4

Closed roni-frantchi closed 3 months ago

roni-frantchi commented 2 years ago

No good reason to use a 3rd party here.
It is only ever used to create the storage_class and csi_service_account using yaml instead of HCL, but the equivalent HCL can be used in hashicorp/kubernetes or even yaml combined with yamldecode().

We could easily make the swap and drop this 3rd party dep.

roni-frantchi commented 2 years ago

Close the 3 issues in env0/k8s-module

roni-frantchi commented 2 years ago

@yaronya can we close this issue?

yaronya commented 2 years ago

No not yet, See comment in #9:

haven't removed the kubectl provider yet because customer use it and they need it to make the transition - otherwise kubectl resources would fail on destroy

chpl commented 3 months ago

There's no upgrade path to the new version of this module and we don't use gavinbunney/kubectl in it.