envato-archive / guide

Document your application with a living component library and styleguide
https://rubygems.org/gems/guide
MIT License
8 stars 3 forks source link

Rework the authorisation system to allow for authentication and be nicer #34

Closed lukearndt closed 8 years ago

lukearndt commented 8 years ago

This change makes it possible to sign in and out from the Guide user interface.

It also makes it a lot cleaner to inject an authorisation system. The host application no longer needs to specify an authorisation system class name in configuration and hope that Guide can constantize it without exploding. Instead, the injection is provided by whatever class the host provides for Guide::BaseController to inherit from. The controller base class injection still uses constantize, but at least now we're back down to one.

The rest is a general cleanup of the surrounding code.

ppj commented 8 years ago

:+1: again with a caveat that i paired on this ¯_(ツ)_/¯