envato-archive / guide

Document your application with a living component library and styleguide
https://rubygems.org/gems/guide
MIT License
8 stars 3 forks source link

Specify supported rails versions #82

Closed zubin closed 6 years ago

zubin commented 6 years ago

Context

Currently it's unclear which versions of rails are supported.

After installing this repo, the build failed mysteriously with:

NoMethodError:
  undefined method `configure' for #<TestApp::Application:0x00007ff52a0fab78>
  Did you mean?  config
# ./spec/test_app/config/environments/test.rb:1:in `<top (required)>'

This is because I had rails 4.0 installed, which satisfied the gem requirements but wasn't compatible with the test app.

Changes

Considerations

zubin commented 6 years ago

@shevaun Added some commits in preparation for rails 5 support.

shevaun commented 6 years ago

LGTM