--wait-for-rc forces ami-spec to wait for the system bootstrap to finish before running tests. This is helpful as sshd can start quite early and our tests might execute before the system is fully booted, giving false failures.
But support was limited to Ubuntu trusty. We also failed with obscure or no error messages if it took no effect.
This PR works to support more OS types and print out explicit warnings when it has no impact.
It also introduces some integration tests. Due to the required security permissions for Xenial those can't be run in Travis, so must be run locally.
--wait-for-rcforces ami-spec to wait for the system bootstrap to finish before running tests. This is helpful assshdcan start quite early and our tests might execute before the system is fully booted, giving false failures.But support was limited to Ubuntu trusty. We also failed with obscure or no error messages if it took no effect.
This PR works to support more OS types and print out explicit warnings when it has no impact. It also introduces some integration tests. Due to the required security permissions for Xenial those can't be run in Travis, so must be run locally.