envato / double_entry

A double-entry accounting system for Ruby applications.
https://rubygems.org/gems/double_entry
MIT License
429 stars 68 forks source link

Remove force: true from create_table #181

Closed swrobel closed 4 years ago

swrobel commented 4 years ago

This seems to have been in the migration since the first commit, but I see no reason for it to be there (and it's generally considered unsafe, so it's better not to have it unless needed)

Context: this behavior is flagged by strong_migrations

orien commented 4 years ago

Thanks. Do you mind adding a line to the change log?

swrobel commented 4 years ago

I can, but that always seems to be where the merge conflicts crop up when I open a bunch of PRs on other repos ... Any chance you could merge the other open PRs and then I could do so?

swrobel commented 4 years ago

Done!

orien commented 4 years ago

Great.

Actually, do you mind adding links to the PRs to resolve the rendering:

[#178]: https://github.com/envato/double_entry/pull/178
[#181]: https://github.com/envato/double_entry/pull/181
swrobel commented 4 years ago

Oh yeah, I always forget there isn't some special magic that just knows to auto-link them. Done!

orien commented 4 years ago

Thank you.