envato / double_entry

A double-entry accounting system for Ruby applications.
https://rubygems.org/gems/double_entry
MIT License
422 stars 68 forks source link

Make the Line detail association optional #184

Closed swrobel closed 4 years ago

swrobel commented 4 years ago

belongs_to associations became required by default unless specified otherwise from Rails 5.0 and this explicitly sets the detail association on Line to optional. I used required: false instead of optional: true because the optional option was only added in Rails 5, but required will work in Rails < 5. Fixes #183

orien commented 4 years ago

Thanks!

ricobl commented 3 years ago

This has been released under 2.0.0.beta5.

cc @swrobel

swrobel commented 3 years ago

@ricobl thanks! I'm still using my branch for #190 & #192 but I'm glad to see there's progress being made towards 2.0 again.