Test against Rails 6.1 - Githubissues

envato / double_entry

A double-entry accounting system for Ruby applications.

https://rubygems.org/gems/double_entry

MIT License

422 stars 68 forks source link

Test against Rails 6.1 #203

Closed andyjdavis closed 3 years ago

andyjdavis commented 3 years ago

This is a potential fix for https://github.com/envato/double_entry/issues/200

The tests pass locally before and after these changes but that isn't surprising given the nature of the changes.

https://railsbump.org/gems/double_entry claims 6.1 is fine. Waiting to see the result of the Travis run. I'm not entirely sure how else to validate this so if this isn't correct or more needs doing let me know :)

ssunday commented 3 years ago

@andyjdavis thank you so much for doing this!

Should it not test for 6.0 and 6.1?

andyjdavis commented 3 years ago

Should it not test for 6.0 and 6.1?

Seems like a good idea @ssunday I have expanded Travis.yml to run the tests against both 6.0 and 6.1

ssunday commented 3 years ago

@orien Hi! Is there anything we can do to help move this forward? Thanks! 😁