False Positive for title=""

envato / envato-theme-check

The WordPress Theme Check plugin for Envato

GNU General Public License v2.0

208 stars 57 forks source link

False Positive for title="" #15

Closed tommusrhodus closed 6 years ago

tommusrhodus commented 6 years ago

REQUIRED: Found title="" in the file variant_templates/subscribe-video-1.php. Do not leave attributes empty.
Line 26: <div class='variant-shortcode vru' data-shortcode-name='contact-form-7' data-param-title='' data-param-id='none'>

We have a data attr called data-param-title that is intentionally left blank for JS to handle it, the plugin picks up the title="" part creating a false positive.

scottparry commented 6 years ago

Thanks for raising! Just fixed in this commit: 79eaf8cd03fe78bcf68f8bbc4630989e937c7f8c