Add checks for the legacy API

simpsora commented 5 years ago

The legacy API is being retired, and we don't want any new themes to use it.

Add two new API-related checks:

Check for the string marketplace.envato.com and throw an error if found (shouldn't be any need to refer to that domain any longer).
Check for references to the legacy API key add/edit page at /api_keys/edit, which also should no longer be in use.

I don't really know how to test this (installing it in WP seems to require a composer.json file, and my hacked-up version didn't work). Some docs around how to use this tool would be great :)

/cc @Stephen-Cronin @scottparry @dtbaker @jacobbednarz

scottparry commented 5 years ago

@simpsora Installing the plugin through WP Admin and just running Envato Theme Check under the Themes Menu should just work: https://envato.d.pr/dNO92I

No need for any composer settings.

simpsora commented 5 years ago

Thanks for that @scottparry! I installed it into my test WP instance and it worked great; can confirm it caught both the error and the warning :+1: (Before I was trying to use the CLI to do it but failing)

Two questions:

How do reviewers know to use this new version?
Is there something similar for WP plugins in codecanyon?

Cheers!

scottparry commented 5 years ago

@simpsora

Reviewers and Authors know to keep checking this repo for updates, most use Github to fetch the latest.
No.

envato / envato-theme-check

Add checks for the legacy API #55