envato / envato-theme-check

The WordPress Theme Check plugin for Envato
GNU General Public License v2.0
208 stars 57 forks source link

false positive on mkdir #59

Closed BackuPs closed 4 years ago

BackuPs commented 4 years ago

Hi Guys,

What is wrong about using $wp_filesystem->mkdir ? I get a false positive on that and the advice to use wp_mkdir_p() but that does not have the ability to parse $chmod (The permissions as octal number) which i need to create a directory and set the permissions! It is definitely not php mkdir ! It is from wordpress filesystem. It can't be wrong on using that.

Please advice !

afbeelding

scottparry commented 4 years ago

You can ignore false positives. $wp_filesystem->mkdir is fine.