search

envato / envato-theme-check

The WordPress Theme Check plugin for Envato
GNU General Public License v2.0
208 stars 57 forks source link

Plugin fails upon checking Block Themes #69

Closed xconsau closed 4 months ago

xconsau commented 2 years ago

The Envato Theme Check plugin needs to be synced with the latest WordPress Theme Check plugin, as it is unable to check the new Block Themes properly. Upon checking native TwentyTwentyTwo theme, it gives many errors related to the old theme system.

REQUIRED: This theme doesn't seem to display tags. Modify it to display tags in appropriate locations.
REQUIRED: .wp-caption css class is needed in your theme css.
REQUIRED: .wp-caption-text css class is needed in your theme css.
REQUIRED: .sticky css class is needed in your theme css.
REQUIRED: .screen-reader-text css class is needed in your theme css. See See: [the Codex](http://codex.wordpress.org/CSS#WordPress_Generated_Classes) for an example implementation.
REQUIRED: .gallery-caption css class is needed in your theme css.
REQUIRED: .bypostauthor css class is needed in your theme css.
REQUIRED: .alignright css class is needed in your theme css.
REQUIRED: .alignleft css class is needed in your theme css.
REQUIRED: .aligncenter css class is needed in your theme css.
INFO: Your theme appears to be in the wrong directory for the theme name. The directory name should match the slug of the theme. This theme's recommended slug and text-domain is twenty-twenty-two.
(If this is a child theme, you can ignore this error.)
REQUIRED: This theme doesn't seem to support the standard avatar functions. Use get_avatar or wp_list_comments to add this support.
REQUIRED: The theme must not used the <title> tags.
REQUIRED: The theme must not call to wp_title().
REQUIRED: The theme doesn't have post pagination code in it. Use posts_nav_link() or paginate_links() or the_posts_pagination() or the_posts_navigation() or next_posts_link() and previous_posts_link() to add post pagination.
REQUIRED: The theme doesn't have comment pagination code in it. Use paginate_comments_links() or the_comments_navigation or the_comments_pagination or next_comments_link() and previous_comments_link() to add comment pagination.
REQUIRED: No reference to add_theme_support( "title-tag" ) was found in the theme.
REQUIRED: No content width has been defined. Example:
if ( ! isset( $content_width ) ) $content_width = 900;
REQUIRED: Could not find the comment-reply script enqueued. See: [Migrating Plugins and Themes to 2.7/Enhanced Comment Display](https://codex.wordpress.org/Migrating_Plugins_and_Themes_to_2.7/Enhanced_Comment_Display)
 <?php if ( is_singular() ) wp_enqueue_script( "comment-reply" ); ?>
REQUIRED: Could not find [wp_list_comments](https://codex.wordpress.org/Template_Tags/wp_list_comments). See: wp_list_comments
 <?php wp_list_comments( $args ); ?>
REQUIRED: Could not find [wp_link_pages](https://codex.wordpress.org/Function_Reference/wp_link_pages). See: wp_link_pages
 <?php wp_link_pages( $args ); ?>
REQUIRED: Could not find [wp_head](https://codex.wordpress.org/Function_Reference/wp_head). See: wp_head
 <?php wp_head(); ?>
REQUIRED: Could not find [wp_footer](https://codex.wordpress.org/Function_Reference/wp_footer). See: wp_footer
 <?php wp_footer(); ?>
REQUIRED: Could not find [wp_body_open](https://make.wordpress.org/themes/2019/03/29/addition-of-new-wp_body_open-hook/). See: wp_body_open
 <?php wp_body_open(); ?>
REQUIRED: Could not find [post_class](https://codex.wordpress.org/Template_Tags/post_class). See: post_class
 <div id="post-<?php the_ID(); ?>" <?php post_class(); ?>>
REQUIRED: Could not find [language_attributes](https://codex.wordpress.org/Function_Reference/language_attributes). See: language_attributes
<html <?php language_attributes(); ?>
REQUIRED: Could not find [comments_template](https://codex.wordpress.org/Template_Tags/comments_template). See: comments_template
 <?php comments_template( $file, $separate_comments ); ?>
REQUIRED: Could not find [comment_form](https://codex.wordpress.org/Template_Tags/comment_form). See: comment_form
 <?php comment_form(); ?>
REQUIRED: Could not find [body_class](https://codex.wordpress.org/Template_Tags/body_class) call in body tag. See: body_class
 <?php body_class( $class ); ?>
REQUIRED: Could not find [add_theme_support](https://codex.wordpress.org/Function_Reference/add_theme_support)( 'automatic-feed-links' ). See: add_theme_support
 <?php add_theme_support( $feature ); ?>
REQUIRED: Could not find DOCTYPE. See: https://codex.wordpress.org/HTML_to_XHTML
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"?>

Upon checking the same theme with the native Theme Check plugin, it passes almost all tests.

WARNING: Your theme appears to be in the wrong directory for the theme name. The directory name must match the slug of the theme. This theme's correct slug and text-domain is twenty-twenty-two. (If this is a child theme, you can ignore this error.)
WARNING: assets/images/ducks.jpg is 768.2 KB in size. Large file sizes have a negative impact on website performance and loading time. Compress images before using them.
RECOMMENDED: No reference to register_block_style was found in the theme. Theme authors are encouraged to implement new block styles as a transition to block themes.
INFO: Only one text-domain is being used in this theme. Make sure it matches the theme's slug correctly so that the theme will be compatible with WordPress.org language packs. The domain found is twentytwentytwo.
webmandesign commented 1 year ago

I can confirm this. Envato Theme Check does not seem to be updated for block themes, unlike WordPress Theme Check plugin is.

Are you guys working on Envato Theme Check update accommodating the WordPress changes?

realthemes commented 4 months ago

@webmandesign , @xconsau Hello, I encountered the same problem (yes, a year later the problem remains) have you had any experience uploading a block theme to the market? how did everything go with review team?

webmandesign commented 4 months ago

Hi @realthemes, you can go ahead and upload a block theme to ThemeForest. From my personal experience they treat each theme individually - sometimes the review process is fast, sometimes slow. I haven't had issue with Envato Theme Check plugin during the review process, though.

realthemes commented 4 months ago

@webmandesign, thank you for the quick response and for sharing your experience

scottparry commented 4 months ago

I have just merged the latest version to add block theme compat to rectify this issue.

Please download and use the new version.