The `is_plugin_active` check probably needs to be a Warning or Info only

envato / envato-theme-check

The WordPress Theme Check plugin for Envato

GNU General Public License v2.0

208 stars 57 forks source link

The `is_plugin_active` check probably needs to be a Warning or Info only #7

Closed Stephen-Cronin closed 6 years ago

Stephen-Cronin commented 6 years ago

@iKreativ I just got pinged on this TGM PA issue

In the context of TGM PA, using is_plugin_active does make sense, so this should probably be an Info or Warning rather than Required. Then the Reviewer can check if it's TGM PA or not.

scottparry commented 6 years ago

Yeah. I'm actually going to have a look at excluding TGM from this check to correct the false positive. If not, I'll switch to WARNING.

Stephen-Cronin commented 6 years ago

Thanks. That would be cool if we could do it!

scottparry commented 6 years ago

Fixed in https://github.com/envato/envato-theme-check/commit/5ce47c277b30f170c9a1f4d5b7ffd993f2c493c9