envato / envato-wordpress-toolkit-library

WordPress Toolkit Library for Envato Marketplace hosted items
71 stars 29 forks source link

Strict standards upgrade class error #10

Open furqanmahmood opened 10 years ago

furqanmahmood commented 10 years ago

While including the envato tool kit library it is throwing following error. the error is displaying in version 3.7 and +

Kindly compatible this library for all versions of wordpress, i have to upload the theme :) waiting for your positive and quick response in this regard.

Strict standards: Declaration of Envato_WordPress_Theme_Upgrader::upgrade() should be compatible with Theme_Upgrader::upgrade($theme, $args = Array) in D:\wamp\www\innov\wp-content\themes\mytheme\inc\envato-wordpress-toolkit-library\class-envato-wordpress-theme-upgrader.php on line 26

While checking the theme from theme check plugin its displaying the list of following errors RECOMMENDED: get_themes found in the file class-envato-wordpress-theme-upgrader.php. Deprecated since version 3.4. Use wp_get_themes() instead.

Line 74: if ( function_exists( 'wp_get_themes' ) )

Line 75: $themes_list = wp_get_themes();

Line 77: $themes_list = get_themes();

Line 232: if ( function_exists( 'wp_get_themes' ) )

Line 233: $installed_themes = wp_get_themes();

Line 235: $installed_themes = get_themes();

RECOMMENDED: get_current_theme found in the file class-envato-wordpress-theme-upgrader.php. Deprecated since version 3.4. Use wp_get_theme() instead.

Line 70: $theme_name = function_exists( 'wp_get_theme' ) ? wp_get_theme()->Name : get_current_theme();

Line 100: $theme_name = get_current_theme();

Please help this out Thank you in advance

Japh commented 10 years ago

Thank you for reporting this, we'll get it fixed for the next release! :)

furqanmahmood commented 10 years ago

That is Great Japh and thank you for the reply.

Could you please tell me that when you are going to release the next version. :) Because i want to upload a new theme so kindly tell me that with these issues and current version of Toolkit Library, whether my theme will be accepted or not ?

Or should i wait for the next release of Envato Tool Kit Library?

Waiting for your quick feedback in this regard. :)

furqanmahmood commented 10 years ago

Hi Japh its been 2 months but there is no update for the new version, when you people are going to launch this .... ???

Waiting for your quick and positive response

Best Regards

anikitas commented 10 years ago

Hello,

Same question here! envato-wordpress-toolkit plugin was updated recently ( 12 May 2014 ).

Do you have a plan date for the new release of the library version? Is it safe to use the current version with WordPress 3.9?

Thank you very much in advance!

BassemN commented 9 years ago

I have the same issue.

BassemN commented 9 years ago

Is there any update about this issue

tbba commented 9 years ago

bump

Hey guys... I cannot believe that this serious issue is open for so long already and nobody cares!

valendesigns commented 9 years ago

I'll look into it and get it sorted for the next version. Sorry for the delay.

BassemN commented 9 years ago

Hi @valendesigns Is this library compatible with WP 4? Is there any due date for the next version please? Many thanks

itsmanuelrc commented 9 years ago

Same issue here. Please solve this soon.

jadeye commented 9 years ago

Hello all/contributors... Today (Dec 2) and still same error.... Anyone??? We will all celebrate 1 year birthday for this bug very soon.... Truly unbelievable :-1:

jadeye commented 9 years ago

For whoever reaches here & is stock, This bug effects bulk install/update... Just manually install/upgrade one by one Good lock

anikitas commented 9 years ago

I cannot wait so i fixed it myself.

For the strict standards problem: You need to initialize the $package as empty array: From:

public function upgrade( $theme, $package ) {

To:

public function upgrade( $theme, $package = array() ) {

In file :class-envato-wordpress-theme-upgrader.php

For the rest i just removed all instances of "get_themes" and "get_current_theme()"

I have no warnings now.

I hope it helps!

tbba commented 9 years ago

HELLO - CAN WE HAVE A FIX PLEASE?