search

envato / exiv2

A simple wrapper around exiv2
MIT License
25 stars 17 forks source link

Force encoding in each and add Ruby 1.8 compatibility #4

Closed jgraichen closed 12 years ago

jgraichen commented 12 years ago

Unfortunately, force_encoding broke Ruby 1.8 compatibility. It also is not applied when calling each directly.

I've moved force_encoding into the each method and check if it is available. On Ruby 1.8 it will not be called, but adjusted specs pass nevertheless (mri-1.8.7, ree-1.8.7, mri-1.9.3).

joho commented 12 years ago

Awesome, good patch.

joho commented 12 years ago

Do you need a version bump and another gem release or do you want to bundle against the repo?

jgraichen commented 12 years ago

I do not need a new version, but it may break for other users still using Ruby 1.8.