envfluids / py2d

Python 2D Navier-Stokes solver
MIT License
12 stars 2 forks source link

eddyViscosity - PiOmega_hat #61

Open rmojgani opened 5 months ago

rmojgani commented 5 months ago

https://github.com/envfluids/py2d/blob/e15e9ba5677ce9a838d1cecac7595f9a640caf60/py2d/Py2D_solver.py#L389C1-L390C74 Is eddyViscosity in

        Omega_hat_temp = RHS/(1+dt*alpha + 0.5*dt*(nu+eddyViscosity)*Ksq)

consistent with PiOmega_hat in

        RHS = Omega1_hat - dt*(convec_hat) + dt*0.5*(nu+eddyViscosity)*diffu_hat - dt*(Fk_hat+PiOmega_hat) + dt*beta*V1_hat
jakharkaran commented 5 months ago

Correct. Eddy viscosity models are using Crank Nicholsoin time integration scheme while PiOmega is using Forward Euler (with an option for Adam Bashforth). We can figure out how to fix this later.