search

envire / envire-envire_core

Core part for the Environment Representation library
BSD 2-Clause "Simplified" License
7 stars 13 forks source link

Fixes linker problem: adds the console_bridge dependency in a couple … #33

Closed Rauldg closed 5 years ago

Rauldg commented 5 years ago

…of CMake places

I think that this should not be necessary because console_bridge is a dependency of class_loader. Maybe there is something missing there that makes the linker fail on the second level dependencies?

In any case, I think that it doesn't hurt. Should be merged?

arneboe commented 5 years ago

As far as I see you are only adding the dependency when building with plugins. In that case the find_package(console_bridge) could be moved inside the if(ENABLE_PLUGINS) block.

arneboe commented 5 years ago

console_bridge is provided by libbase-logging.so. Are you building in an environment where no base-logging exists?

planthaber commented 5 years ago

console_bridge is provided by libbase-logging.so. Are you building in an environment where no base-logging exists?

Not anymore: We separated that some time ago:

https://github.com/rock-core/base-console_bridge

arneboe commented 5 years ago

In entern it is still provided by base-logging? Or maybe that is the problem? When I ask pkg-config where to find console_bridge it points to base-logging.

planthaber commented 5 years ago

Console bridge is header only, i don't see why there is a linker problem...

Rauldg commented 5 years ago

I figured out that the installation script I was using was missing some compiler flags for class loader. It apparently needs these:

 -D CMAKE_CXX_FLAGS:STRING=-fPIC -D BUILD_SHARED_LIBS=ON

Also I had to set the LD_LIBRARY_PATH and now these fixes are not required. I think we can close this without merging.