search

enviroCar / enviroCar-app

enviroCar Android Application
https://envirocar.org
GNU General Public License v3.0
88 stars 154 forks source link

Set ime option to edit text in login activity #407

Closed arvindnegi1 closed 4 years ago

arvindnegi1 commented 4 years ago

Describe the bug Click on keyboard enter or next button it is expanding the edit text rather then pointing directly to next edit text.

To Reproduce Steps to reproduce the behavior: 1.Open login activity.

  1. enter user name.
  2. click on keyboard next button. Not pointing to next edit text rather it expanding the edit text of username.
    Gif of the current behaviour

Why we need this For better user experience click on next in keyboard should point to next edit text.

arvindnegi1 commented 4 years ago

@dewall sir, cai i work on this?

csk1827 commented 4 years ago

It is a valid issue. You can start working on this.

VibhorChinda commented 4 years ago

@csk1827 sir and @arvindnegi1 sir i think the issue (https://github.com/enviroCar/enviroCar-app/issues/398) would handle this issue too.

arvindnegi1 commented 4 years ago

@VibhorChinda sir, you must be replacing EditText with com.google.android.material.textfield.TextInputEditText but that will not solve this issue ;)

VibhorChinda commented 4 years ago

@arvindnegi1 sir, if i would change the text fields i would enable their the toggle option as well as the single line input option which i guess would solve this issue and also in addition would provide the toggle option to us.

arvindnegi1 commented 4 years ago

@VibhorChinda sir, but that will not handle implicit submit after click on go in password edit text field for sure. We have to check for ime action in SignInActivity.java .

VibhorChinda commented 4 years ago

@arvindnegi1 sir, I guess what you were pointing out in this issue was the problem of text fields expanding rather than moving to next text field.

I guess you should make a new issue describing how to handle the implicit action. Don't take me wrong but is it necessary for implementing the implicit action when there is a login button.

arvindnegi1 commented 4 years ago

@VibhorChinda sir, i clearly mentioned in "Set ime option to edit text in login activity" means i am also setting ime action to edit text password so it is very much clear setting ime action to password edit text should perform the submit for that we have to add some code in .java. Thank you ;).