search

enviroCar / enviroCar-app

enviroCar Android Application
https://envirocar.org
GNU General Public License v3.0
88 stars 154 forks source link

Add a place holder text when no tracks are uploaded #454

Closed neel1998 closed 2 years ago

neel1998 commented 4 years ago

Currently the uploaded tracks screen is blank when there are no tracks uploaded. Adding a place holder text would be nice since blank screen doesnt look good and is confusing.

Current State

I would like to work on this issue

cdhiraj40 commented 2 years ago

hey, @asaikarthikeya I still see this happening. I updated from the repo and tried. I recently downloaded it on another directory and tried but it still shows me a blank screen

I have worked on it and it doesn't show a blank screen after my implementation. If you also see the blank screen then I would like to work on it.

cdhiraj40 commented 2 years ago

before

https://user-images.githubusercontent.com/75211982/133569320-d9a1100b-c373-4a4f-bd7e-398b12e59d91.mp4

cdhiraj40 commented 2 years ago

after:

https://user-images.githubusercontent.com/75211982/133569440-259a3749-c700-4fad-a1d7-30de5cb8fe11.mp4

cdhiraj40 commented 2 years ago

@SebaDro can you confirm about the

hey, @asaikarthikeya I still see this happening. I updated from the repo and tried. I recently downloaded it on another directory and tried but it still shows me a blank screen

I have worked on it and it doesn't show a blank screen after my implementation. If you also see the blank screen then I would like to work on it.

@SebaDro can you confirm this?

asaikarthikeya commented 2 years ago

You can work on this @cdhiraj40. Please make your PR with the relevant code changes. Thanks :)

asaikarthikeya commented 2 years ago

@SebaDro If i understand the commit correctly, only displaying background image after an operation is handled in https://github.com/enviroCar/enviroCar-app/commit/02aeb0bbcaed2727ca23b442eea70400ee7e4a66. Tracks should be checked and background image should be set when upload track is opened. ;)

SebaDro commented 2 years ago

I was about to answer, that the described issue has been fixed in 02aeb0b, but you were just faster ;-). Actually, you're right. There is still a blank screen, when opening the uploaded tracks fragment second time. So, feel free to work on it

cdhiraj40 commented 2 years ago

I was about to answer, that the described issue has been fixed in 02aeb0b, but you were just faster ;-). Actually, you're right. There is still a blank screen, when opening the uploaded tracks fragment second time. So, feel free to work on it

I already did sir. Thanks :)

asaikarthikeya commented 2 years ago

I was about to answer, that the described issue has been fixed in 02aeb0b, but you were just faster ;-). Actually, you're right. There is still a blank screen, when opening the uploaded tracks fragment second time. So, feel free to work on it

Yes, I have been following the code changes regularly and clearing the issues/PR the have been resolved ;)