search

enviroCar / enviroCar-app

enviroCar Android Application
https://envirocar.org
GNU General Public License v3.0
88 stars 154 forks source link

Replace "Terms and conditions" and "Privacy statment" dialogs with link to web page #589

Open asaikarthikeya opened 3 years ago

asaikarthikeya commented 3 years ago

The dialogs of "Terms and conditions" and "Privacy statement" in the signup can be replaced by opening a browser page.

https://user-images.githubusercontent.com/70392921/110351763-2c630c00-805b-11eb-9416-ac031678fd0a.mp4

shahabrar7746 commented 3 years ago

Hey This looks amazing issue for me.And want to contribute on this issue.Will u let me contribute on this issue

asaikarthikeya commented 2 years ago

Hello @shahabrar7746 and @DhirajChauhan40. This issue is open to work, any one of you can take this up. First PR would be considered. Thank you :)

cdhiraj40 commented 2 years ago

@asaikarthikeya I'm done with the code. I wanted to ask what would be the toast message when they are redirecting to the site also, do we need this?

       agreementManager.showLatestTermsOfUseDialogObservable(this)
                .subscribe(tou -> LOG.info("Closed Dialog"));
asaikarthikeya commented 2 years ago

@asaikarthikeya I'm done with the code. I wanted to ask what would be the toast message when they are redirecting to the site also, do we need this?

       agreementManager.showLatestTermsOfUseDialogObservable(this)
                .subscribe(tou -> LOG.info("Closed Dialog"));

No need of a toast message. Post the PR and we can revise it accordingly in the PR. Thank you.

SebaDro commented 2 years ago

Hey. Why do you find, this is more useful then showing the dialogs embedded within the app?

cdhiraj40 commented 2 years ago

Hey. Why do you find, this is more useful then showing the dialogs embedded within the app?

It's really compact space to read such important info and as per UI having terms in a dialogue box don't look good in my opinion.

asaikarthikeya commented 2 years ago

Hey. Why do you find, this is more useful then showing the dialogs embedded within the app?

In many succesfull apps, Privacy statments are shown either by navigating to web link or to another fragment which contains this info. Generally large text is not displayed in the dialog box as it is difficult to read. Displaying dialogs is kind of old fashion now, all apps got updated in the last 2-3 years.

Jdbarad commented 2 years ago

this issue is ready to open?

cdhiraj40 commented 2 years ago

hey @Jdbarad the PR for the issue has been made here -> https://github.com/enviroCar/enviroCar-app/pull/799