search

enviroCar / enviroCar-app

enviroCar Android Application
https://envirocar.org
GNU General Public License v3.0
88 stars 154 forks source link

Register here and Sign In here as plain text #600

Closed Bhavya-22 closed 2 years ago

Bhavya-22 commented 3 years ago

Issue:- As register here and Sign in here are simply plain text so it doesn't giving a good response whether it is clicked or not. As a user point of view, if he/she has network issues then it will be unable to understand whether app has a issue or net.

How will I fix this:-

I will make sign in here and register here as button suitable with the colour codes of app so it will look more responsive to user as button clicked can be seen also it is convenient as most Login/SignUp page has button for this generally. Also i will make above text to Register,signin text as white so it will look more clearly on blue background

Login Page SignUp Page

rohittrimalle commented 3 years ago

i can contribute on this issue

rohittrimalle commented 3 years ago

i want add animation on button anyone guide me Capture Capture1

Bhavya-22 commented 3 years ago

@rohittrimalle Basically I am going to solve it by myself. Now I am having my academic exams that's why i am unable to work right now. Although thank you for showing interest in this issue as you have almost done it so please let me know what animation are you trying to add. If i know it then i can add that part along with mentioning your work to PR so both are able to create a PR reagrding this.

Bhavya-22 commented 3 years ago

PR for this has been created. https://github.com/enviroCar/enviroCar-app/pull/628

Bhavya-22 commented 3 years ago

@rohittrimalle see that in your work there are shadows behind sign in here and register here also after making sign in here as button/cardview you didn't make the background as one there are two backgrounds behind them. And you forget to add space between register here and the text above it. For now I made the PR with this improvements but I hope my comment will be useful for you

asaikarthikeya commented 2 years ago

In all the popular apps. The register here/ create new account buttons is always present in text form. Eg - Instagram, Facebook etc..Hence, I am closing this issue. feel free to ask if you have any doubts. Thanks for sharing your thoughts @Bhavya-22 ;)

Bhavya-22 commented 2 years ago

But atleast make them focusable so that when user click the click can be observed/feel

asaikarthikeya commented 2 years ago

Whole sign in and Sign up activities need to be completely redesigned. Sometime in the future. All the design things will be considered. Thank you