search

enviroCar / enviroCar-app

enviroCar Android Application
https://envirocar.org
GNU General Public License v3.0
88 stars 154 forks source link

Bug: The bluetooth, GPS etc buttons #611

Closed ritish099 closed 2 years ago

ritish099 commented 3 years ago

Once the Bluetooth, GPS buttons are turned ON . Again clicking on the button doesn't turn it off.

Explanation of issue: Open the app and go to the above screen. Turn on Bluetooth or GPS by clicking on the respective icon. Once they are turned On. They will turn into blue clour. Now try again clicking on that icon to turn off the feature(Bluetooth or GPS or other) the button will not respond.

Expected Behavior: Button Should response and turn off the Bluetooth or GPS or etc whichever clicked on

ScreenShot

ritish099 commented 3 years ago

I am Working on it

asaikarthikeya commented 3 years ago

@ritish099 Could you please elaborate the issue. Thank you

ritish099 commented 3 years ago

Open the app and go to the above screen. Turn on Bluetooth or GPS by clicking on the respective icon. Once they are turned On. They will turn into blue clour. Now try again clicking on that icon to turn off the feature(Bluetooth or GPS or other) the button will not respond. Expected Behavior: Button Should response and turn off the Bluetooth or GPS or etc whichever clicked on

ritish099 commented 3 years ago

If we want the user to turn on Bluetooth and other features while using the app. Then we can just simply turn them on whenever they open the app(You can see this feature in many production apps) but if we are giving user the liberty to Turn ON then i think he/she should have the liberty to turn it OFF. The user might just want to use Bluetooth and not GPS. Or any combination of features.

ritish099 commented 3 years ago

Either we should Turn all the features ON automatically whenever the user opens the app. or we should give him the liberty to turn off some features if we are giving him/her liberty to turn it ON

asaikarthikeya commented 3 years ago

Good points.Work after the mentor confirms this issue :)

ritish099 commented 3 years ago

Can you mention the mentor ?

Bhavya-22 commented 3 years ago

@bpross-52n is the mentor for enviroCar project

ritish099 commented 3 years ago

@Bhavya-22 thanks

Bhavya-22 commented 3 years ago

Also you can mention @arvindnegi1 sir as he is also one of the contributors or you can see contributors list and tag according. But for Gsoc point of view @bpross-52n is mentor for this

asaikarthikeya commented 2 years ago

Merged into the master branch!