Closed Bhavya-22 closed 2 years ago
I will be working on this
Ok if in #607 plus icon work is done so I will do the rest as I mentioned in my PR
@Bhavya-22 you can change the string file but please don't forget to change the translated string.
@arvindnegi1 sir I will implement string English version at place ok kommentar not going to delete kommentar value just going to change the Id and string in eng version(if needed) to make it comment
@arvindnegi1 sir I will implement string English version at place ok kommentar not going to delete kommentar value just going to change the Id and string in eng version(if needed) to make it comment
I mean add string id in english version and also add corresponding german version with same id in values-de strings_logbook thanks!
Ok sir I will do it accordingly thank you for your guidance.
Sir is it alright to use strings/values send_log_comments_label by this first it is not hard coded now and I have not changed any de strings values
@arvindnegi1 sir when we delete a fueling the snack bar text "fueling is successfully deleted from server" is showing but I think as a user point of view from server is not necessary so can I edit this text too or just let it be as it is
@arvindnegi1 sir when we delete a fueling the snack bar text "fueling is successfully deleted from server" is showing but I think as a user point of view from server is not necessary so can I edit this text too or just let it be as it is
Or if from server should not be deleted so should I add the same to successful Snack bar text also (Your fueling is successfully added to server or just your fueling is successfully added).
Please let me know so that no comments on review is required.(or I can just change both delete and add text and you can review it on PR)
PR for this is created
@arvindnegi1 Sir please review it and also let me know about the comment I wrote.
For now i have added the "to server" text to successful adding fueling snackbar too.
### Issue :- After opening logbook it is just showing a blue button but there is no sign in it(+ sign to signify add). Also for general app it is showing kommentar not Comments. And there is no confirmation regarding successfully fueling added .
How I will fix this:- I will add a + sign in that button in white colour so that it can be seen easily. Also make kommentar as comments in general string file. And add a snackbar/toast for successfully fueling added.