search

enviroCar / enviroCar-app

enviroCar Android Application
https://envirocar.org
GNU General Public License v3.0
88 stars 154 forks source link

Icons to make more responsive #662

Closed Bhavya-22 closed 2 years ago

Bhavya-22 commented 3 years ago

Issue :- When bluetooth, OBD, GPS, Car are off or on red then on click the icons the respective button to on are directed but when they are blue on click nothing will happen.

How will I fix this :- When icons are blue i will make a toast message with icon focusable so that icon will be seen responsive and on click icon respective toast message will be seen. Like on click bluetooth icon the toast message will be "Device's Bluetooth is on".

I will be working on this issue

asaikarthikeya commented 3 years ago

Duplicate #611

Bhavya-22 commented 3 years ago

@asaikarthikeya @ritish099 trying to make it off again on click I am trying to show the meaning of that blue icon again on click. Its different from #611. Hope you got my point.

Bhavya-22 commented 3 years ago

If @ritish099 feature is accepted then we can do one think on single click it will be off and on long click it will show the meaning. For now I will implement toast on single click.

ritish099 commented 3 years ago

@Bhavya-22 cooool ☺

asaikarthikeya commented 2 years ago

This issue proposed 2 features

  1. Onclick when red colour is resolved by #762
  2. In my opinion it is too much of information. I feel blue-red colour combination is sufficient to understand whether Bluetooth is on/off. @SebaDro sir, if you feel that on long click feature to be useful then i will implement that or else we can close this PR. Open to here you thoughts on this sir. Thank you ;)
SebaDro commented 2 years ago

The red/blue combination should be clear enough for indicating the button state. In addition, the icons are self speaking. Therefore, there is no need for a long click feature. Since #762 solves parts of this issue, it can be considered as done.

SebaDro commented 2 years ago

Duplicate of #611. I wil close it for now but feel free to open it again, if there is still a valid issue.