search

enviroCar / enviroCar-app

enviroCar Android Application
https://envirocar.org
GNU General Public License v3.0
88 stars 154 forks source link

Fixed #428 Login,Register,Logout made as icons #686

Closed Bhavya-22 closed 2 years ago

Bhavya-22 commented 3 years ago

Made login, register, logout as icons (login and register as different also) with text enabled i.e. on long press the text/title corresponding to each icon will be shown. Also for icons I have used vector assets.

Bhavya-22 commented 3 years ago

@arvindnegi1 Sir please review it

Akash-Ramjyothi commented 3 years ago

@Bhavya-22 thank you for your contributions, I can see that you have Implemented the icons on the menu_dashboard. Can you please provide a Screenshot of the changes made in the Interface for easy review? Also, it would be great if you have used Material Icons in case you haven't.

Bhavya-22 commented 3 years ago

Basically, I have used vector assets as they can manage themselves according to different pixels or resolutions. But if material icons are better, then I will definitely switch to them.

Bhavya-22 commented 3 years ago

Here are the screenshots requested by you. Please let me know if any other things are required. Also, sorry for such a late reply. Login_Icon

Logout_Icon

Bhavya-22 commented 3 years ago

I will merge all my PRs regarding sign in and sign out page and commit all on one PR.

asaikarthikeya commented 2 years ago

@Bhavya-22 This enhancement is not required in the current state of the App. Hence i am closing this. Feel free to ask if you have any doubts. Thank you.