search

enviroCar / enviroCar-app

enviroCar Android Application
https://envirocar.org
GNU General Public License v3.0
88 stars 154 forks source link

Automatically close keyboard after filling a parameter in car selection. #795

Closed asaikarthikeya closed 2 years ago

asaikarthikeya commented 2 years ago

Description

While creating a new car, After user succesfully add a HSN/TSN value the keyboard should close automatically. Simialar behaviour is expected when entering all attributes while creating a new car.

asaikarthikeya commented 2 years ago

@DhirajChauhan40 You can take this up. This will be good starting point. Feel free ask if you have any doubts. Thanks

cdhiraj40 commented 2 years ago

@asaikarthikeya do you want the keyboard to close for every attribute or close after when all the attributes are added? also where to see HSN/TSN value? if activity name will be mentioned it will be helpful

cdhiraj40 commented 2 years ago

Currently its like this:

https://user-images.githubusercontent.com/75211982/131094131-96b56988-5f63-4191-96ca-4ea3d0b5e04e.mp4

cdhiraj40 commented 2 years ago

@asaikarthikeya do you want the keyboard to close for every attribute or close after when all the attributes are added? also where to see HSN/TSN value? if activity name will be mentioned it will be helpful

I can try to implement something where if a person clicks on an empty part of screen then keyboard will hide. (just an idea yet, can take longer)

asaikarthikeya commented 2 years ago

@asaikarthikeya do you want the keyboard to close for every attribute or close after when all the attributes are added? also where to see HSN/TSN value? if activity name will be mentioned it will be helpful

after every attribute.

asaikarthikeya commented 2 years ago

@asaikarthikeya do you want the keyboard to close for every attribute or close after when all the attributes are added? also where to see HSN/TSN value? if activity name will be mentioned it will be helpful

I can try to implement something where if a person clicks on an empty part of screen then keyboard will hide. (just an idea yet, can take longer)

This is already done, Commit is present in another branch. Develop will be updated with that by tonight.

cdhiraj40 commented 2 years ago

@asaikarthikeya do you want the keyboard to close for every attribute or close after when all the attributes are added? also where to see HSN/TSN value? if the activity name will be mentioned it will be helpful

after every attribute.

okay sure will do and what is HSN/TSN ? or do I just have to do for new car attributes

asaikarthikeya commented 2 years ago

@asaikarthikeya do you want the keyboard to close for every attribute or close after when all the attributes are added? also where to see HSN/TSN value? if the activity name will be mentioned it will be helpful

after every attribute.

okay sure will do and what is HSN/TSN ? or do I just have to do for new car attributes

As i see the above screenrecording, you are using master branch to test the app. Please run the app with the develop branch. This Car selection process has been updated last year and not yet merged in the master. You will find HSN/TSN parameters if you run the app on the develop branch. :)

cdhiraj40 commented 2 years ago

@asaikarthikeya do you want the keyboard to close for every attribute or close after when all the attributes are added? also where to see HSN/TSN value? if the activity name will be mentioned it will be helpful

after every attribute.

okay sure will do and what is HSN/TSN ? or do I just have to do for new car attributes

As i see the above screenrecording, you are using master branch to test the app. Please run the app with the develop branch. This Car selection process has been updated last year and not yet merged in the master. You will find HSN/TSN parameters if you run the app on the develop branch. :)

oh okay sorry I had installed the app from play store

cdhiraj40 commented 2 years ago

@asaikarthikeya i need help implementing it, i have the code for hide keyboard .

my approach was to check if the values added by user are not empty then close the keyboard but I'm not able to implement it. (maybe because I didn't know much about AutoCompleteTextView, after reading the documentation about it i am still unable to implement it)

asaikarthikeya commented 2 years ago

@asaikarthikeya i need help implementing it, i have the code for hide keyboard .

my approach was to check if the values added by user are not empty then close the keyboard but I'm not able to implement it. (maybe because I didn't know much about AutoCompleteTextView, after reading the documentation about it i am still unable to implement it)

Sure, Mail me your approach and findings at a.saikarthikeya@gmail.com. Lets try to figure this. Thanks.

cdhiraj40 commented 2 years ago

@asaikarthikeya i need help implementing it, i have the code for hide keyboard . my approach was to check if the values added by user are not empty then close the keyboard but I'm not able to implement it. (maybe because I didn't know much about AutoCompleteTextView, after reading the documentation about it i am still unable to implement it)

Sure, Mail me your approach and findings at a.saikarthikeya@gmail.com. Lets try to figure this. Thanks.

sure.

cdhiraj40 commented 2 years ago

@asaikarthikeya okay its working woo! thanks

asaikarthikeya commented 2 years ago

PR made for this issue #802

cdhiraj40 commented 2 years ago

@asaikarthikeya Heyy I am already done with this work and ready to make PR you know I was waiting for the other PR to be done so I can make new

cdhiraj40 commented 2 years ago

I couldn't make a new PR cause of a branch issue that's why I was waiting for the old PR to be merged you said its gonna take a while

@asaikarthikeya Heyy I am already done with this work and ready to make PR you know I was waiting for the other PR to be done so I can make new

you can already see the PR which I have made for this (closed one mentioned earlier ) I closed it cause I was getting the old commits back I had already said in #799 conversations that if you merge this then I can create new for this issue :( sorry if I'm commenting too much but I just wanted to merge my both PRs which were ready and when I saw someone else did when I said I was done with the work I felt bad, again sorry.

asaikarthikeya commented 2 years ago

@cdhiraj40 Yes, I know that you were working on this issue. I am unaware that @FabianWessel is working on this issue. The PR made for this issue is not merged yet, May be @SebaDro and @FabianWessel have not looked at this issue and our conversation . Lets wait to hear @SebaDro Sir views about this.

And regarding the opening multiple PR's, You can create multiple branches from the develop and work on each branch separately and create PR's. If you are have doubts regarding the creation of multiple PRs, do mail me i will help you :) thanks.

cdhiraj40 commented 2 years ago

@cdhiraj40 Yes, I know that you were working on this issue. I am unaware that @FabianWessel is working on this issue. The PR made for this issue is not merged yet, May be @SebaDro and @FabianWessel have not looked at this issue and our conversation . Lets wait to hear @SebaDro Sir views about this.

And regarding the opening multiple PR's, You can create multiple branches from the develop and work on each branch separately and create PR's. If you are have doubts regarding the creation of multiple PRs, do mail me i will help you :) thanks.

okayy okayy a relief, thanks for considering my points.

yes i know about opening multiple PRs but I made a mistake by directly working in my fork's develop branch and I have committed the changes in the old PR so whenever I make a new branch the old commits will come to change this either I will have to make a new PR after the old one gets merged(which I have decided) or delete the fork, refork and make the old PR again which I had already done so I didn't go that way

SebaDro commented 2 years ago

Hey guys. Sorry, I was not aware of your conversation, so that I asked @FabianWessel to work on this issue. Since I've already reviewed his implementation I'm looking forward to merge #802.

However, the SendLogFileActivity still does not support closing the keyboard when clicking in the background. Maybe, you can work on this? If you're ok with it, please create a separate issue for it, so that I can close this one. Subsequently you can create a PR based on the latest develop branch.

cdhiraj40 commented 2 years ago

Hey guys. Sorry, I was not aware of your conversation, so that I asked @FabianWessel to work on this issue. Since I've already reviewed his implementation I'm looking forward to merge #802.

However, the SendLogFileActivity still does not support closing the keyboard when clicking in the background. Maybe, you can work on this? If you're ok with it, please create a separate issue for it, so that I can close this one. Subsequently, you can create a PR based on the latest developed branch.

hey @SebaDro it's fine I can try to work on that issue thanks for the response and suggestion. you can close the issue :)

asaikarthikeya commented 2 years ago

Merged into the master branch!