search

enviroCar / enviroCar-app

enviroCar Android Application
https://envirocar.org
GNU General Public License v3.0
88 stars 154 forks source link

```SendLogFileActivity``` does not support closing the keyboard when clicking in the background. #803

Closed cdhiraj40 closed 1 year ago

cdhiraj40 commented 2 years ago

@SebaDro hey SebaDro as we talked about earlier I would like to work on this issue.

SebaDro commented 2 years ago

Great. Feel free to go ahead

cdhiraj40 commented 2 years ago

@asaikarthikeya I'm done with the code, I will make a new PR as soon as you merge the old PR.

cdhiraj40 commented 2 years ago

https://user-images.githubusercontent.com/75211982/131890736-2fde0eb7-ade2-45b2-b99a-f2805a83ccf5.mp4

SebaDro commented 2 years ago

802 has just been merged. Feel free to go ahead.

cdhiraj40 commented 2 years ago

802 has just been merged. Feel free to go ahead.

no actually i meant my old PR, i mistakenly started working on develop branch so even if i make new branch, the old commits come so thats why the old PR should get merge #799

SebaDro commented 2 years ago

No need to wait for the old PR for being merged ;-). Just create a separate fix/name branch based on the current develop branch , implement the proposed fix and create a new pull request for it.

SebaDro commented 1 year ago

Has been fixed with c80d2767.