search

enviroCar / enviroCar-app

enviroCar Android Application
https://envirocar.org
GNU General Public License v3.0
88 stars 154 forks source link

SendLogFileActivity does not support closing the keyboard when clicking in the background. #804

Closed cdhiraj40 closed 1 year ago

cdhiraj40 commented 2 years ago

fixes #803

cdhiraj40 commented 2 years ago

okay finally. you can check @asaikarthikeya.

asaikarthikeya commented 2 years ago

@cdhiraj40 Great that you figure this out, And the implementation LGTM. As, I have previously mentioned to you about the PR merge, new contribution guildlines are in progress and this PR will be rechecked and merged in 1-2 weeks. You can continue to work on other issues if you wish to, by creating another branch from develop. ;)

cdhiraj40 commented 2 years ago

@asaikarthikeya yes sure this time i won't forget about the branch ;-)

cdhiraj40 commented 2 years ago

@asaikarthikeya I have a better approach to handle this and the approach can take care of all the fragments once added to the parent activity.

no need to add hide keyboard everywhere :)

asaikarthikeya commented 2 years ago

@cdhiraj40 Oh great! Kindly share you findings here..so that we can check and see if the new proposed way works for all the cases. If the proposed way seems convincing then you can go ahead. Thanks ;-)

SebaDro commented 1 year ago

Has been fixed with c80d2767, which provides a smarter way hiding the keyboard, since it prevents iterating about each view elemtn and keeps the keyboard open when scrolling.