search

enviroCar / enviroCar-app

enviroCar Android Application
https://envirocar.org
GNU General Public License v3.0
88 stars 154 forks source link

Welcome message is shown to the user in Dashboard, when changing the bottom navigation framgents. #805

Closed asaikarthikeya closed 2 years ago

asaikarthikeya commented 2 years ago

Welcome message should be only shown to the user after succesfull login.

cdhiraj40 commented 2 years ago

Hey, @asaikarthikeya I tried this, the reason it keeps on showing is that we are calling the function updateUserLogin again and again in onCreateView when I commented out the part it only showed once when we open the app (but obv the stats didn't update) making a new function specifically for the toast/snackbar and then trying might help, I'm doing the work if I get it I will make PR if you all are okay

asaikarthikeya commented 2 years ago

@cdhiraj40 Okay, Feel free to go ahead. Thanks

cdhiraj40 commented 2 years ago

@asaikarthikeya I have coded that snackbar only shows the every time you enter the app but I'm not able to do it after logging the reason can be that it doesn't go directly to the home screen after logging (intent is not there)

asaikarthikeya commented 2 years ago

@asaikarthikeya I have coded that snackbar only shows the every time you enter the app but I'm not able to do it after logging the reason can be that it doesn't go directly to the home screen after logging (intent is not there)

Seems like a new bug got added in our develop branch, Are you able to reproduce this @SebaDro sir ? Previously the navigation used to be present, may be this got disabled after updating the develop branch last week.

asaikarthikeya commented 2 years ago

@cdhiraj40 I have deleted that comment as the log-in credentials are visible in the screen recording. I do understand the issue hear, screenrecording shares personal info too ;)

cdhiraj40 commented 2 years ago

@cdhiraj40 I have deleted that comment as the log-in credentials are visible in the screen recording :)

yess will take next time thanks ;-)

cdhiraj40 commented 2 years ago

hey @asaikarthikeya I'm done with this issue (including redirecting to dashboard fragment )if the team is not working I can make PR

cdhiraj40 commented 2 years ago

hey @asaikarthikeya I'm done with this issue (including redirecting to dashboard fragment )if the team is not working I can make PR

https://user-images.githubusercontent.com/75211982/132127498-4ee1c208-1a03-4d88-900b-7380ac155007.mp4

as you can see here after login we directly go to the dashboard page and we get the snackbar only once even if we navigate. we also get a welcome message every time we open/launch the app (when signed in), I can remove this feature if you want. and I didn't show the login credentials too :)

asaikarthikeya commented 2 years ago

Perfect! Please consider raising the PR. Many thanks for resolving this.🙂

cdhiraj40 commented 2 years ago

Perfect! Please consider raising the PR. Many thanks for resolving this.🙂

sure. should i make 2 PRs, one for login intent and other for this issue? or both in one is fine :)

asaikarthikeya commented 2 years ago

Do it in multiple commits, Its fine if you do it in 1 PR as the number of lines of code is not very big. Thanks.

SebaDro commented 2 years ago

Fixed by dba654c and b71ba2c.

asaikarthikeya commented 2 years ago

Merged into the master branch!