No actionbar in Settings

[cdhiraj40]

The back button is missing in setting screen.

[cdhiraj40]

https://user-images.githubusercontent.com/75211982/133747748-d594ead9-22b5-432e-ad0b-fecff07b049a.mp4

[cdhiraj40]

@asaikarthikeya I am done with work, I will make PR if you approve. Thanks

[asaikarthikeya]

Sure, go ahead! thanks.

[cdhiraj40]

Sure, go ahead! thanks.

i will make it tomorrow. my laptop is getting debugged(repaired) :)

[SebaDro]

What's the thing with this issue? Would you please, provide a detailed description for the issue, in accordance to our contributing guidelines

[asaikarthikeya]

What's the thing with this issue? Would you please, provide a detailed description for the issue, in accordance to our contributing guidelines

The back button on the top toolbar is missing in setting screen.

[asaikarthikeya]

@SebaDro Please refer @dewall sir's message in #427, where Dewall sir has mentioned about missing of back option in settings.

[SebaDro]

Yes, @dewall is right. If you have a closer look on the different views, you will notice that the toolbar layout is not consistent across the whole app. There are 3 different layouts:

1. enviroCar logo with back button
2. enviroCar logo without back button
3. text header with back button In addition, there is another interesting design on the help view which switches the header layout using an animation.

Hence, we first should discuss which layout should be preferred for future releases.

[Jdbarad]

I want to contribute to this issue, I also started work on it.

[SebaDro]

Yeah, great. Just go ahead

[asaikarthikeya]

@Jdbarad @SebaDro This issue has been already worked and is yet to be reviewed - PR #821. Please work on a issue that doesnot have a pull request attacked to it. Thanks :)

[cdhiraj40]

Same

What's the thing with this issue? Would you please, provide a detailed description for the issue, in accordance to our contributing guidelines

The back button on the top toolbar is missing in setting screen.

The same issue is there for StartRecordingActivity, any reason sir? @SebaDro @asaikarthikeya

[SebaDro]

Yes and no :point_down:

Yes, @dewall is right. If you have a closer look on the different views, you will notice that the toolbar layout is not consistent across the whole app. There are 3 different layouts:

1. enviroCar logo with back button
2. enviroCar logo without back button
3. text header with back button In addition, there is another interesting design on the help view which switches the header layout using an animation.

Hence, we first should discuss which layout should be preferred for future releases.

[cdhiraj40]

Yes and no :point_down:

Yes, @dewall is right. If you have a closer look on the different views, you will notice that the toolbar layout is not consistent across the whole app. There are 3 different layouts:

1. enviroCar logo with back button
2. enviroCar logo without back button
3. text header with back button In addition, there is another interesting design on the help view which switches the header layout using an animation.

Hence, we first should discuss which layout should be preferred for future releases.

yes i know that sir but that activity doesnt have any toolbar

[asaikarthikeya]

Yes and no :point_down:

Yes, @dewall is right. If you have a closer look on the different views, you will notice that the toolbar layout is not consistent across the whole app. There are 3 different layouts:

1. enviroCar logo with back button
2. enviroCar logo without back button
3. text header with back button In addition, there is another interesting design on the help view which switches the header layout using an animation.

Hence, we first should discuss which layout should be preferred for future releases.

yes i know that sir but that activity doesnt have any toolbar

Hello Dhiraj, Do you think a toolbar looks good in the recording screen? Toolbar is intentionally ignored in the recording screen. The back option is also not a must have feature in settings screen. Always try to think in the opposite way(how it will be if I have a toolbar, does it improve the UI?) before asking. Some things are designed intentional keeping several other parameters in mind. Thank you🙂

[cdhiraj40]

Yes and no point_down

Yes, @dewall is right. If you have a closer look on the different views, you will notice that the toolbar layout is not consistent across the whole app. There are 3 different layouts:

1. enviroCar logo with back button
2. enviroCar logo without back button
3. text header with back button In addition, there is another interesting design on the help view which switches the header layout using an animation.

Hence, we first should discuss which layout should be preferred for future releases.

yes i know that sir but that activity doesnt have any toolbar

Hello Dhiraj, Do you think a toolbar looks good in the recording screen? Toolbar is intentionally ignored in the recording screen. The back option is also not a must have feature in settings screen. Always try to think in the opposite way( who it will be if I have a toolbar, does it improve the UI?) before asking. Some things are designed intentional keeping several other parameters in mind. Thank youslightly_smiling_face

I meant the back option and not the toolbar in recording screen activity, sorry for the inconvenience. I Will sure try to think that way before asking next time.

[pree-T]

Is this issue still open? May I work on it? Can someone help me?

[cdhiraj40]

Is this issue still open? May I work on it? Can someone help me?

the issue is not open for work, there is an ongoing discussion for this.

[madhurmehta007]

@cdhiraj40 Is this issue still in discussion or I can work upon it ?