search

enviroCar / enviroCar-app

enviroCar Android Application
https://envirocar.org
GNU General Public License v3.0
88 stars 154 forks source link

Consistent usage of dialogs in the app #871

Open cdhiraj40 opened 2 years ago

cdhiraj40 commented 2 years ago

fixes #860 & addition to PR #747

69014902-3c5e-4bfe-87bf-70a09b8a89b5

81a35d67-e6af-4f45-bc85-288ac1fedcf9

cdhiraj40 commented 2 years ago

Hey @cdhiraj40. Kindly refer #752. Please use this format for the dialogs with progress bars. Thanks :)

sure will do :) but I have one doubt as the dialog box used earlier for uploading all tracks had percentage show below which used to update, so do I have to add here? (it used to update using custom view) image

asaikarthikeya commented 2 years ago

@cdhiraj40 I see that there are 2 dialogs, 1 for uploading all tracks which uses percentage. And another dialog which uploads 1 track and it has circular progress bar. Am i right? You can prefer the procedure used in #752 for single track uploading dialog and for all tracks keep the percentage dialog.

cdhiraj40 commented 2 years ago

@cdhiraj40 I see that there are 2 dialogs, 1 for uploading all tracks which uses percentage. And another dialog which uploads 1 track and it has circular progress bar. Am i right? You can prefer the procedure used in #752 for single track uploading dialog and for all tracks keep the percentage dialog.

sure, will update the PR soon :)

asaikarthikeya commented 2 years ago

Hey @cdhiraj40, Just a small suggestion i would like to add. Kindly change the PR title here, as this coincides with another PR- #747. Mentioning the older PR number in this PR is sufficent to state that both are related.

Also, when you add new changes after reviewing, do specify the change as the commit message. please refrain using "requested changes" as the commit message. Commit messages should specify the changes in that commit. requested changes doesnot specify the changes clearly. Thanks :)

cdhiraj40 commented 2 years ago

Hey @cdhiraj40, Just a small suggestion i would like to add. Kindly change the PR title here, as this coincides with another PR- #747. Mentioning the older PR number in this PR is sufficent to state that both are related.

sure, I will do it so that there is no confusion :)

Also, when you add new changes after reviewing, do specify the change as the commit message. please refrain from using "requested changes" as the commit message. Commit messages should specify the changes in that commit. requested changes do not specify the changes clearly.

Sure my bad, that is indeed a good suggestion I will try to take care from here. Thanks for this. I will revert and commit the change soon :)