search

enviroCar / enviroCar-app

enviroCar Android Application
https://envirocar.org
GNU General Public License v3.0
89 stars 158 forks source link

Inconsistency in ViewPager slide animation #891

Open ken1000minus7 opened 2 years ago

ken1000minus7 commented 2 years ago

There is some inconsistency in the slide animation during navigation of the fragments in the BaseMainActivity. For some cases, the navigation is abrupt and no sliding animation appears. This is mainly evident during navigation from

  1. `TrackListPagerFragment` to `DashboardFragment`
  2. `TrackListPagerFragment` to `OthersFragment`

https://user-images.githubusercontent.com/78747188/158239706-120b0fd6-e507-4715-ad9f-df09bdc16e61.mp4

One way I am thinking of solving this is by replacing ViewPager used here with ViewPager2. ViewPager2 provides improved and smoother sliding animations during navigation and besides providing other advantages over ViewPager, it is the latest method of paging fragments and is receiving active development support. ViewPager2 can also be used in place of ViewPager for the paging inside the TrackListPagerFragment

cdhiraj40 commented 2 years ago

I am not sure if animation is that big of any problem here, also do read the contribution guidelines it talks about animation pull requests. But I do believe that it is worth upgrading to ViewPager2 as it provides way better functionality than viewpager and will help in reusing the views.

ken1000minus7 commented 2 years ago

Well I did read the contribution guidelines and as far as I remember they said that an issue must be opened in case of animations. Nevertheless, I was referring to the problem of the ViewPager not functioning in the desired way which is quite evident in the lack of proper animations during navigation and abruptness while navigating so I think this is more of an issue regarding ViewPager rather than animations 🤔 and for this, I believe shifting to ViewPager2 will be a much better option in the long term provided the advantages it offers 😄