Add bin icon to delete car in my cars scree & Add option to share app in settings screen

Jdbarad commented 2 years ago

https://user-images.githubusercontent.com/93068379/163801757-d18fe064-2c0b-4a1a-8710-bcf0c99e717a.mp4

Jdbarad commented 1 year ago

@SebaDro review PR

SebaDro commented 1 year ago

Hey @Jdbarad. Thanks for your contributions. Your button based delete function looks good to me. However, you should only provide one new feature per pull request. So just create a new pull request that is based on the develop branch for the bin icon implementation. You could also provide a separate pull request for the sharing feature, but this must be discussed internally, first. So if you do so, it won't be merged in the near future.

In addition, the existing space in the car selection view is very limited for each car row. So placing the bin icon beside the radio button is not a good choice, because in the end there is less space for the car name text.

See the figures below. If you have cars with longer names, you will get a problem with the new approach.

Current view	New view

Please, think about a more user friendly design and follow my review comments. If you do so, I will consider it for merge.

enviroCar / enviroCar-app

Add bin icon to delete car in my cars scree & Add option to share app in settings screen #913