search

enviroCar / enviroCar-app

enviroCar Android Application
https://envirocar.org
GNU General Public License v3.0
87 stars 153 forks source link

Locked Scrolling in Dashboard fragment #951

Open Akash-Ramjyothi opened 1 year ago

Akash-Ramjyothi commented 1 year ago

Fixes: #950.

Description:

Programmatically have set the NestedScrollingEnabled in the Dashboard fragment to be false as there is no generic requirement for this particular screen to be Scrollable. It would also improve the user experience and interaction within the screen while navigating.

Current Dashboard fragment:

https://user-images.githubusercontent.com/54114888/184918047-22e7f3f1-8ec5-4fd3-9518-5c86a3071b8d.mp4

Scrolling locked Dashboard fragment:

https://user-images.githubusercontent.com/54114888/184920362-8d7f49ec-229a-4f6b-b36d-440e6452810d.mp4

cdhiraj40 commented 1 year ago

@Akash-Ramjyothi I think the reason it's scrollable is for small screens. 🤔

Akash-Ramjyothi commented 1 year ago

@cdhiraj40 since the app is responsive, that would not be an issue right.

cdhiraj40 commented 1 year ago

@cdhiraj40 since the app is responsive, that would not be an issue right.

What do you mean by responsive? Can you try the dashboard fragment on a small screen in an emulator? I think if you lock there then only some of the part will be shown

Akash-Ramjyothi commented 1 year ago

@cdhiraj40 that is a really good idea to test this case. I will perform the required action and update.

SebaDro commented 1 year ago

As far as I can say is that the Dashboard screen is not shown in his full shape on my smartphone, which has a smaller screen. Thus, it necessary that scrolling is enabled. Have you checked it in an emulator as mentioned in your previous comment?