search

enviroCar / enviroCar-app

enviroCar Android Application
https://envirocar.org
GNU General Public License v3.0
87 stars 153 forks source link

Optimisation: Replacing listView in CarSelectionActivity with Recycler View #968

Open Jdbarad opened 1 year ago

Jdbarad commented 1 year ago

https://user-images.githubusercontent.com/93068379/204893791-9715716f-ff0f-4745-b0f6-e152ef72d9fc.mp4

Jdbarad commented 1 year ago

Description

This activity presently contains listView for showing the list of cars which is not an efficient approach. This listView needs to be replaced with RecyclerView having well-designed CardViews which will lead to a better user interface as well as better app performance.

How did it get fixed?

Replace ListView with RecyclerView, Create CarSelectionRecyclerAdapter for mCarRecyclerView Create a function & method that is also required in CarSelectionListAdapter. Also added CardView for a better user experience.

Conclusion

Now, CarSelectionActivity uses RecyclerView, That better for App performance. Also Solved Broken car selection radio button #927

Reviews

I like to invite @SebaDro Sir & @asaikarthikeya sir to review this PR and give me suggestions

Jdbarad commented 1 year ago

@SebaDro Sir Please Review this PR