enviroCar / enviroCar-app

enviroCar Android Application
https://envirocar.org
GNU General Public License v3.0
88 stars 154 forks source link

Change units of consumption and co2 emisson #97

Closed jakobmoellers closed 10 years ago

jakobmoellers commented 10 years ago

Hello, i do not know where to change the units for consumption and co2 emission on the server. Now, they are g/s for co2 and l/s for consumption. They should be: kg/s for co2 l/h for consumption @autermann , @ChristopherStephan or @ubergesundheit , can you explain this to me or change the units to what I specified if applicable? The current units are not human readable because they have too many decimal digits. I changed the format so that the app delivers these values now but we have to specify the units on the server. Thanks for your help!

jakobmoellers commented 10 years ago

Sorry! kg/h for co2

ChristopherStephan commented 10 years ago

Done.

curl -X POST -H "Content-Type: application/json" -H "X-Token: bla" -H "X-User: bla" -d '{"name": "CO2", "unit": "kg/h" }' https://giv-car.uni-muenster.de/stable/rest/phenomenons

curl -X POST -H "Content-Type: application/json" -H "X-Token: bla" -H "X-User: bla" -d '{"name": "Consumption", "unit": "l/h" }' https://giv-car.uni-muenster.de/stable/rest/phenomenons

jakobmoellers commented 10 years ago

Okay thank you very much.

nuest commented 10 years ago

I already commented on this in an issue for the website, but because to me it is not made clear what this "unit change" actually means:

Imho it makes sense to differentiate here between units for storage and unit for display. Are the sensors actually so accurate and/or precise that i makes sense to store the detailed values? Or will you just change the "kilo" stuff and keep the precision after the comma? At least any rounding should happen for display, not before upload (unless the sensors are complete rubbish, but we don't konw that yet, do we?).

Or maybe just clarify :-)

oraibalmegdadi commented 10 years ago

rpm

the Rpm values are very bigger than other values, the Rpm unit is u/min,, can we change it to u/h ??

ubergesundheit commented 10 years ago

rpm stands for revolutions per minute :)

jakobmoellers commented 10 years ago

it won't get better when you do u/h... ;-) and no: r/min is an international standard

dwilhelm89 commented 10 years ago

I guess no car really display values betwenn 0 and 10.000.

The common way is to user either RPM_1000 or RPM_100 (e.g. http://www.egauges.com/images/vdo/Large_d/A2C53408405-S-BR.jpg)

jakobmoellers commented 10 years ago

this is just a visualization question. we will not change meaningful values into something not useful just because a visualization cannot cope well with the values.

oraibalmegdadi commented 10 years ago

RPM and RPH both are valid in science

dwilhelm89 commented 10 years ago

@oraibalmegdadi you can simply recalculate the value for the graph as I have done it on the profile page

jakobmoellers commented 10 years ago

You cannot simply group unrelated values in one bar graph... this makes no sense... remember the sign that Werner Kuhn likes to show: Population: 5000 Founded: 1854 Sum: 6854 ;-)

oraibalmegdadi commented 10 years ago

and i think the all the units should be either in mints or hours

jakobmoellers commented 10 years ago

even when RPH is used sometimes in science: in the context of CARS, definitely not.