search

enviroCar / enviroCar-app

enviroCar Android Application
https://envirocar.org
GNU General Public License v3.0
89 stars 158 forks source link

Migrated the app design to material 3 #973

Closed madhurmehta007 closed 1 year ago

madhurmehta007 commented 1 year ago

Fixes : #972

Description:

1) Changed the material dependency version to 1.6.0 2) Changed the theme to Material 3 in styles_envirocar.xml 3) Updated the bottom navigation design for better current tab visibility

Updated Bottom Navigation:

https://user-images.githubusercontent.com/77354138/218589376-7e3d9d90-da5c-4ef2-9349-2640e0632f0a.mp4

SebaDro commented 1 year ago

Hi @madhurmehta007. Thanks for your contribution. Unfortunately, our contributing guidelines require a minimal relevance for pull requests to be considered for merge. As far as I can see, your pull requests just provide small adjustments in layout. Hence, I will close it, unless you can proof the importance of the layout update.

cdhiraj40 commented 1 year ago

I agree that Android Material Design 3 brings significant changes to the user interface and user experience of the app.

But switching to the new design system requires significant effort and resources, and I don't think so it's suitable for us now! As the app does what it is good at and don't see any user complaining about the UX too!

Also, @madhurmehta007 do keep in mind that just adding a new library or upgrading to a new version of the library is not always beneficial! It depends on a lot of factors for a production app.

Feel free to close this one @SebaDro!