search

enviroCar / enviroCar-app

enviroCar Android Application
https://envirocar.org
GNU General Public License v3.0
87 stars 153 forks source link

Showing ProgressDialog at the time of bluetooth pairing #977

Closed SanjaySargam closed 9 months ago

SanjaySargam commented 1 year ago

Fixes #969

ScreenRecording

https://user-images.githubusercontent.com/65113071/223193999-09b75057-a828-48da-8b8c-1906e0a6f65e.mp4

SanjaySargam commented 1 year ago

Hi @SanjaySargam . Thanks for your contribution.

I really like the solution for showing a progress bar when pairing performs. Just a small suggestion: we already have a DialogUtils helper class that provides some methods to create a MaterialAlertDialogBuilder with progress bar. It would be great, if you could use this helper class to create the dialog, since it also applies the enviroCar theme on the dialog, which preserves consistence in the UX

What do you think about it?

Ok I will use existing Dialog in helper class

SanjaySargam commented 9 months ago

Please, change the color of the Bluetooth icon to be white and select the develop branch as target branch for your pull request. After that I will merge it.

@SebaDro Ok To achieve this, I need to delete this PR and make another one right?

SebaDro commented 9 months ago

Well, I think it's possible to edit the present pull request and change the target branch. If not, just create a new one and close the old.