Shell needs to be a global / command setting

environmental-forecasting / model-ensembler

Model Ensemble tool for batch workflows on HPCs

https://pypi.org/project/model-ensembler/

MIT License

13 stars 1 forks source link

Shell needs to be a global / command setting #37

Closed JimCircadian closed 2 years ago

JimCircadian commented 2 years ago

execute_command contained this line:

shell = '/usr/bin/bash' if not shell else shell

Which is rather specific and problematic on non-CentOS distros (which is what I develop on) as it might not exist. Also, setting the shell on checks or in the config is not sufficient as shells are spawned with SLURM cluster checks now that the python API has been dropped. This needs to be a CLI argument at least.