added .free_symbols to Variable.

environmentalscience / essm

This package contains helpers to deal with physical variables and units.

https://environmentalscience.github.io/essm/

GNU General Public License v2.0

12 stars 5 forks source link

added .free_symbols to Variable. #28

Closed schymans closed 7 years ago

schymans commented 7 years ago

At the moment, the .free_symbols method on physical variables and equations returns {}. This PR should give a dictionary of physical variables in an equation or expression.

jirikuncar commented 7 years ago

Fixed in SymPy.

jirikuncar commented 7 years ago

@schymans can you try to rebase on top of master? I am not really sure how to resolve some of the conflicts.

schymans commented 7 years ago

I thought I had! I'll check again. I actually realised that Quantities are not returned as free symbols in Sympy, so the current behaviour is consistent. I am now creating some functions in utils.py to achieve what I wanted originally. Therefore, I'll close this PR and start a new one.