search

envistaInteractive / eslint-config-enspire

ESLint configuration used at Enspire Commerce
http://www.enspirecommerce.com/
2 stars 0 forks source link

Unwanted rule behaviour #2

Closed onel0p3z closed 7 years ago

onel0p3z commented 7 years ago

dot-notation rule complains about:

joi.string().default('defValue');

We need to allow it.

onel0p3z commented 7 years ago

also complains about try...catch

stivenson commented 7 years ago

everything will go up in this branch: https://github.com/envistaInteractive/eslint-config-enspire/tree/fix/dot-notation

stivenson commented 7 years ago

hi @cristianPerez @zetogk please, for check if this solution https://github.com/envistaInteractive/eslint-config-enspire/commit/de78381b4823c337e5e80ca62c521cbf1de75677 is good for this issue in their machines too, 💯

stivenson commented 7 years ago

Hi all !! @onel0p3z @cristianPerez @zetogk @cperez08 I propose this structured for the tests, what do you all think? https://github.com/envistaInteractive/eslint-config-enspire/blob/fix/dot-notation/test/common.js

onel0p3z commented 7 years ago

https://github.com/envistaInteractive/eslint-config-enspire/pull/5 solves this issue