search

envoylabs / whoami

An NFT-based user and smart contract nameservice
Apache License 2.0
16 stars 8 forks source link

What is the correct burn behaviour & send/transfer behaviour #38

Closed the-frey closed 2 years ago

the-frey commented 2 years ago

It's likely that transfer/send will need to be overridden to do the correct thing in terms of clearing metadata and/or burning with this contract.

Not sure, so really this probably needs to be checked in terms of sending the NFT to a compatible contract(?) and then seeing what happens.

the-frey commented 2 years ago

Okay, so it doesn't need to be burned, as control of the token stays with this contract, it's just that the owner changes.

But probably does need its meta cleared. Definitely will do for web of trust time

https://github.com/CosmWasm/cw-nfts/blob/main/contracts/cw721-base/src/execute.rs#L271

This has a knock-on for #33 as the token isn't burned on transfer, so you can't end up with dupes unless the token is specifically burned.

Of course this does mean that you could transfer, another contract could take actions, you could later burn, but that's getting into edge-casey/advanced usage that is as-yet undefined.